yeyus / AndroidCourse-TwitterClient

Sample light twitter client
0 stars 0 forks source link

[Android Bootcamp] Project 4: Twitter Client - Ready for Review #5

Open yeyus opened 9 years ago

yeyus commented 9 years ago

Hi Nathan!

My app is complete, pls review. /cc @codepathreview @codepath

Please see attached README to review items and GIF https://github.com/yeyus/AndroidCourse-TwitterClient/blob/master/README.md

codepathreview commented 9 years ago

:+1: Project looks good. The way you have architected the fragment looks good, but still a few functionalities can still be abstracted out, good job otherwise. And good job on making the UI clean and twitter-like

I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.