search

yilozt / rounded-window-corners

A gnome-shell extensions that try to add rounded corners for all windows
GNU General Public License v3.0
464 stars 47 forks source link

Publish onto extensions.gnome.org? #145

Open Fenimoure opened 11 months ago

Fenimoure commented 11 months ago

It would be pretty nice to have this extension available that way. thanks.

khaustovdn commented 11 months ago

yes, please

Aworldc commented 11 months ago

it is?

https://extensions.gnome.org/extension/5237/rounded-window-corners/

cfouche3005 commented 11 months ago

I think he mean publish the update to extensions.gnome.org

ghost commented 11 months ago

is there anything stopping the upload of the new version to the site?

leaf-penguin commented 10 months ago

is there anything stopping the upload of the new version to the site?

Looks like v12 was pushed to the gnome extensions website but the update was rejected. The issues seem pretty small.

https://extensions.gnome.org/review/47995

benjamin051000 commented 10 months ago

This is kind of a duplicate of #147 by the way. Just linking the two together. :)

benjamin051000 commented 10 months ago

Here's a copy of the rejection notes (see link @leaf-penguin posted above):

  1. No need to use this.initTranslation() (line 18 prefs.js):

    Consider this method deprecated. Only specify gettext-domain in metadata.json. GNOME Shell can automatically initiate the translation for you when it sees the gettext-domain key in metadata.json.

    Port Guide 45: Extension Utils

  2. You should uninit_settings() in disable() and window close request in prefs.js.

    window.connect('close-request', () => {
    uninit_settings();
});
devNamanG commented 10 months ago

Is it expected to be fixed soon? Or are any PRs open for it?

AJCxZ0 commented 10 months ago

What can we do to help make this happen? I am tired of snagging things on the sharp corners of my windows.

devNamanG commented 10 months ago

What can we do to help make this happen?

So basically you can follow the steps in the README and compile and install on your machine, I did the same, it's temporary till the extension comes up as supported on EGO for Shell v45.

AJCxZ0 commented 9 months ago

Thank you for the advice, @namangor04.

So basically you can follow the steps in the README...

Please excuse me for being insufficiently clear. By "this" I meant the purpose stated in the issue, i.e. to publish on Rounded Window Corners so that it gets automagically picked up and updated on GNOME 45+.

coolkys commented 9 months ago

I guess someone could follow the feedback in the rejection note and make a PR, then wait for the author to approve and re-push to gnome extensions. However, by the looks of things on this repo, I think the author is either busy with life, or otherwise MIA.

in4matix commented 9 months ago

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

coolkys commented 9 months ago

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Your repo should be the de facto way to install this extension in Gnome 45 for now. Thanks!

Memnoc commented 9 months ago

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Thanks for the time spent doing this, I have starred your repo and was missing this extension to run alacritty with no decoration and the same gnome rounded corners I have in Debian