search

ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
31 stars 13 forks source link

Handle login mode when older launcher triggers launcher #102

Closed iLLiCiTiT closed 6 months ago

iLLiCiTiT commented 6 months ago

Changelog Description

Startup logic can handle login mode correctly when older ayon-launcher was used to launch new ayon launcher version.

Additional info

Login mode was introduced in 1.0.1, when user launches e.g. version 1.0.0 which will, by bundle definition, relaunch to version 1.0.1. In that case AYON_API_KEY is set from 1.0.0 but AYON_IN_LOGIN_MODE is not set, so launcher will resolve as "not in login mode" which is incorrect assumption. This PR is handling cases when the first launched launcher version is before 1.0.1.

Question is if this PR makes sense as 1.0.1 still won't be able to handle it and at the time of 1.0.2 release will probably none of users use older ayon launchers.

Testing notes:

  1. Make a build and installer from this PR.
  2. Upload it to server and use the version in your production bundle.
  3. Launch older ayon launcher e.g. 1.0.0 (must be older than 1.0.1).
  4. AYON launcher should launch, use uploaded version and should be in login mode (Login action in tray should allow to change login).