search

ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
31 stars 13 forks source link

Shell script: Fix condition in make.sh script #122

Closed iLLiCiTiT closed 1 month ago

iLLiCiTiT commented 2 months ago

Changelog Description

The condition caused [: -eq: unary operator expected which should be fixed now.

Testing notes

  1. Make sure .poetry is not in root of repository.
  2. Run ./tools/make.sh create-env.
  3. Script should not complain about invalid syntax.
iLLiCiTiT commented 1 month ago

Testing notes would be great.

I though this change does not really need any testing?

Lypsolon commented 1 month ago

Testing notes would be great.

I though this change does not really need any testing?

Well, you put me for code review, and I will admit I don't know how and when the if test would be true. So, to check if it's actually doing the expected behaviour, I would need testing notes.

if you just want me to look at the code, yes, it looks correct, but that's not a review.

iLLiCiTiT commented 1 month ago

if you just want me to look at the code, yes, it looks correct, but that's not a review.

It is review. Code review does not always require testing. Discussion for different place...