Closed iLLiCiTiT closed 1 month ago
Testing notes would be great.
I though this change does not really need any testing?
Testing notes would be great.
I though this change does not really need any testing?
Well, you put me for code review, and I will admit I don't know how and when the if test would be true. So, to check if it's actually doing the expected behaviour, I would need testing notes.
if you just want me to look at the code, yes, it looks correct, but that's not a review.
if you just want me to look at the code, yes, it looks correct, but that's not a review.
It is review. Code review does not always require testing. Discussion for different place...
Changelog Description
The condition caused
[: -eq: unary operator expected
which should be fixed now.Testing notes
.poetry
is not in root of repository../tools/make.sh create-env
.