search

ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
31 stars 13 forks source link

Chore: SystemExit is not considered as error #133

Closed iLLiCiTiT closed 1 month ago

iLLiCiTiT commented 1 month ago

Changelog Description

Reraise SystemExit exception.

Additional info

SystemExit is exception raised when sys.exit is called. It should not be considered as failed process.

BigRoy commented 1 month ago

Without this PR in tray > admin console

I mean, this seems promising: image image

I suppose that'd always still break with this PR?

Where should I best test this from within launcher specifically? I mean the change makes sense - but I'm not sure what bug it solves? Or is my example above, exactly what this should solve?

iLLiCiTiT commented 1 month ago

I mean the change makes sense - but I'm not sure what bug it solves?

AYON launcher process is now always considered as failed, even if is ended with sys.exit(0)...

iLLiCiTiT commented 1 month ago

I'm stupid, I though we're capturing BaseException, but there is only Exception so we don't need to capture this case. Closing.