Closed iLLiCiTiT closed 1 month ago
I still think it is correct to use POETRY_HOME
if set explicitly by the user. It should work the same as with other variables like PATH
, or PYTHONHOME
or LD_LIBRARY_PATH
.
so where is:
poetry_home_root="$repo_root/.poetry"
should be something like poetry_home_root = $POETRY_HOME or "$repo_root/.poetry"
I still think it is correct to use POETRY_HOME if set explicitly by the user. It should work the same as with other variables like PATH, or PYTHONHOME or LD_LIBRARY_PATH.
Did you know about anyone who would like to use different location for poetry in ayon launcher? We have scripts based on that location.
Changelog Description
Manage.ps1 and make.sh scripts do not rely on
POETRY_HOME
environment variable but always use relative path to repository.Additional info
The scripts did rely on the environment variable value and did set the variable only if was not set already. If there is global env variable set for user, or user have terminal which has set the env variable from different script it uses wrong path which leads to confusion and potentially broken environment.
The environment variable is set only when create-env is called to define target path, which is not possible with arguments.
Testing notes:
./.poetry/
with it's content (and./.venv/
).POETRY_HOME
to some random directory../manage.ps1 create-env
on windows or./make.sh create-env
on linux/macOsPOETRY_HOME
../manage.ps1 run
on windows or./make.sh run
on linux/macOs.POETRY_HOME
is not set.