ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
34 stars 14 forks source link

Chore: Add distro and pyside2 information to installer filename #158

Closed iLLiCiTiT closed 2 months ago

iLLiCiTiT commented 2 months ago

Changelog Description

Installer filename contains information about used pyside2 and on linux also contains distribution short .

Additional info

It is PITA to find out for which distribution was laucher created and if was created with pyside2 or pyside6, this should help a little. Server still does support only one linux installer, but at least we're able to find out which is used.

Testing notes:

  1. Create linux installer.
  2. Filename should automatically contain distro name.
  3. If --use-pyside2 is used, the filename also contains -pyside2.

Resolves https://github.com/ynput/ayon-launcher/issues/128

fabiaserra commented 2 months ago

You missed adding distro_short argument to the _find_matching_installer function too, otherwise:

Traceback (most recent call last):
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 363, in <module>
    main()
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 347, in main
    func(**result_dict)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 243, in cli_upload
    create_installer(api, installer_info, force)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 185, in create_installer
    matched_installer = _find_matching_installer(api, installer_info)
  File "/builds/coreweave/pipeline/ayon/ayon-launcher/tools/installer_post_process.py", line 166, in _find_matching_installer
    return InstallerInfo(
TypeError: __init__() missing 1 required positional argument: 'distro_short'