ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
34 stars 14 forks source link

Shim: Install location #169

Open iLLiCiTiT opened 2 months ago

iLLiCiTiT commented 2 months ago

Please describe the feature you have in mind and explain what the current shortcomings are?

There was raised question about installation location of shim executable. Right now on windows is (by default) shim installed to %LOCALAPPDATA%/Ynput/AYON/shim even if AYON launcher is installed to Program files. Only way how to change the location is with AYON_LAUNCHER_STORAGE_DIR env variable -> that also changes where addons and dependency packages are downloaded.

This raised few questions.

  1. Big issue is that shim location is "user specific" and shim won't work on multi-user machine -> considering webactions. Resolved with https://github.com/ynput/ayon-launcher/pull/177
  2. Second issue is that shim path is not "universal" across machines.

How would you imagine the implementation of the feature?

What should probably happen is that shim would be installed to C:/ProgramData folder instead of LOCALAPPDATA - need to be validated if it would break something.

That means it can't be affected with existing environment variables AYON_LAUNCHER_STORAGE_DIR and AYON_LAUNCHER_LOCAL_DIR. Raising new question if AYON_LAUNCHER_STORAGE_DIR should lead to ProgramData by default instead of LOCALAPPDATA (and how to make it somewhat backwards compatible).

Or just use Program files if AYON launcher is install program files and user dir if user dir is used.

Linux

The same issue can be said about linux too. On linux we have the same problem, we should probably look into appdirs (or platformdirs) module for equivalent location to ProgramData?