search

ynput / ayon-launcher

AYON desktop application launcher
Apache License 2.0
34 stars 15 forks source link

Enhancement: Use dataclasses instead of attrs #6

Open iLLiCiTiT opened 1 year ago

iLLiCiTiT commented 1 year ago

Description

This was a suggestion, that we should replace attrs in distribution logic with dataclasses. I've personally never used them yet so I'm not sure how much work it is, but it looks similar with datatype checks.

BigRoy commented 8 months ago

Any reason why it was recommended one over the other? Would we get certain benefits from doing the change?

iLLiCiTiT commented 8 months ago

Would we get certain benefits from doing the change?

Well, dataclasses is built-in python module with direct typehint support, whereas attrs is added dependency without simple typehinting.

BigRoy commented 8 months ago

Good enough for me! :)