more marker support

[jgravois]

looking at your Renderer support, i just wanted to make sure you aware of this project:

https://github.com/esri/Leaflet.shapeMarkers

[ynunokawa]

I have not taken a deeper look yet. However I just know that esri-leaflet-renderers use it. https://github.com/Esri/esri-leaflet-renderers/blob/master/src/Symbols/PointSymbol.js#L104-L122

I think that L.esri.WebMap should replace a method of creating symbols with esri-leaflet-renderers if a feature layer has drawingInfo in WebMap JSON.

[ynunokawa]

I'd propose to add new option of L.esri.FeatureLayer like metadata to include drawingInfo and geometryType. Because it will be able to render using drawingInfo in WebMap JSON with esri-leaflet-renderers. To perform this idea, L.esri.WebMap must create metadata as geojson and add it into L.esri.FeatureLayer.

https://github.com/Esri/esri-leaflet-renderers/blob/master/src/FeatureLayerHook.js#L16-L24

if (this.options.metadata) {
  // Rendering with drawingInfo in WebMap JSON!
  this._setRenderers(this.options.metadata);
}
else {
  this.metadata(function (error, response) {
    if (error) {
      return;
    } if (response && response.drawingInfo) {
      this._setRenderers(response);
    } if (this._alreadyAdded) {
      this.setStyle(this._originalStyle);
    }
  }, this);
}

@jgravois What do you think about this idea?

[ynunokawa]

I'm looking at similar issues.

esri/esri-leaflet-renderers/issues/51 Esri/esri-leaflet/issues/570

[jgravois]

@jgravois What do you think about this idea?

sorry i just saw this! would adding an optional metadata property to the featureLayer constructor still be helpful to you?

[ynunokawa]

@jgravois Thank you, John. it's all right now! :smiley: