ynunokawa / L.esri.WebMap

A leaflet plugin to display ArcGIS Web Map.
MIT License
22 stars 21 forks source link

include compiled plugin code in tags/releases #42

Closed jgravois closed 8 years ago

jgravois commented 8 years ago

https://github.com/Esri/esri-leaflet/blob/master/scripts/release.sh#L17

you might also consider using jsdelivr for cdn because they can pick up git tags automatically

for now i'll point at a specific commit (because pointing at master isn't going to work anymore) https://github.com/Esri/esri-leaflet-doc/commit/19d7d10c2f7a49f43fbd3638d03534c7bd042c54

ynunokawa commented 8 years ago

Thanks, I’ll give it a try 👍

ynunokawa commented 8 years ago

They are my tasks.

# Built Files
dist

Is this enough? :octocat:

jgravois commented 8 years ago

sounds like you should be good to me!

jgravois commented 8 years ago

just wanted to let you know that i tagged 2.0.3 of renderers. also, my girlfriend wants us to take another trip to Japan to come visit you!

ynunokawa commented 8 years ago

Surprised! Are you in Japan now?? 🇯🇵 🚴

ynunokawa commented 8 years ago

I saw it wrong and thought that you are coming here! Please come visit Japan :smile:

ynunokawa commented 8 years ago

merged and hosted! https://cdn.jsdelivr.net/leaflet.esri.webmap/0.3.3/esri-leaflet-webmap.js

jgravois commented 8 years ago

:fireworks:

ynunokawa commented 8 years ago

Done! Thanks @jgravois 😄