Support fully FeatureCollection

ynunokawa / L.esri.WebMap

A leaflet plugin to display ArcGIS Web Map.

MIT License

22 stars 21 forks source link

Support fully FeatureCollection #50

Open ynunokawa opened 8 years ago

ynunokawa commented 8 years ago

FeatureCollection is not able to display features if a geometry type is either polyline or polygon.. (#49)

Polyline
- ?webmap=49e2793251a946ec9d146a9dd57ef0a0
Polygon
- ?webmap=546e94ac62674154a11615250e9a9fb6

I got an error massage as the below. Uncaught TypeError: Cannot read property 'call' of undefined [Map.js:1]

Maps with a bug related to this issue

[x] ?webmap=49e2793251a946ec9d146a9dd57ef0a0
[ ] ?webmap=546e94ac62674154a11615250e9a9fb6
[x] ?webmap=a7c6c7d0348f45bebd78e5cdb644a17b

ynunokawa commented 8 years ago

it does not cause this issue? not a geometry type but ajax to get a data? https://github.com/ynunokawa/L.esri.WebMap/blob/master/src/FeatureCollection/FeatureCollection.js#L35-L44

ynunokawa commented 8 years ago

I found an additional issue related to this issue.

?webmap=a7c6c7d0348f45bebd78e5cdb644a17b

this layer named 'path' has no featureCollection property and we should get featureCollection from a portal using itemId.

we have to review and update OperationalLayer.js and FeatureCollection.js for a operationalLayer of Feature Collection without featureCollection property.

ynunokawa commented 7 years ago

I got an error massage as the below. Uncaught TypeError: Cannot read property 'call' of undefined [Map.js:1]

This issue is solved by removing renderer property of FeatureCollection or CSVLayer. Because it override existing one :smiling_imp: https://github.com/Leaflet/Leaflet/blob/ed1a612e6fc4084f6d39899c83f8d9ce1195250a/src/layer/vector/Renderer.js#L121