Open krystian3w opened 4 years ago
I can't recreate the popup so impossible for me to test right now 😒
Does it appear on first page load or after going to the site a number of times or staying on the site for extended timeframe?
For my only after first visit on homepage or when direct open first video/live link.
May need remove all YouTube
cookies (pop-up may not use localstorage).
Unable see this on /user/
&/channel/
(/c/
) "section". Pop-up should stop direct opened video after ~3 seconds and change video frame into thumbnail
.
I still can't recreate on US IP with first visit in firefox temporary container with no preset cookies. Maybe EU only (will test on VPN) or some other A/B test such as browser or OS?
Test link for direct link to video https://www.youtube.com/watch?v=jXsdKpOWL1U
Test link to video at 8s mark https://www.youtube.com/watch?v=jXsdKpOWL1U?t=8
Good links, here also I see:
pl | en (uk) |
Now also have this pop-up with Firefox and "containers".
Are you on Polish IP for both screenshots? Want to see if I can recreate as much of your environment as possible. Glad they are appearing on those test links for you because I can't get them to appear for me on US IP 🤔but at least have video to test on knowing you can see it.
Yes - both Polish IP, language change in Chrome settings or via glitch with YouTube settings for guest in right top corner:
The language changes after refreshing and any cookie is generated about "I've already seen a pushy popup about the recommended login" to hide this pop-up via Google Idea.
US
no have that pop-up (Miami VPN).
I rule out that it can be hidden by blocking request/resource, because I see after change VPN to Polish localization.
I just connected to Polish VPN and on first load get the popup!
IMO only that link is "stable"/"constant":
<a class="yt-simple-endpoint style-scope yt-formatted-string"
spellcheck="false"
href="https://support.google.com/youtube/?p=sign_in"
rel="nofollow"
target="_blank"
dir="auto">Dowiedz się więcej / Learn more</a>
why not just these 2 cosmetic filters for popup signin prompt?
youtube.com##.opened
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
.opened
we have with other name:
"ytd-pop-up-overlay" "iron-overlay-backdrop
"
so is no needed.
yt-upsell-dialog-renderer
maybe is too generic - maybe generate fail similar as Fanboy Annoyance:
+! Youtube TV promos
+youtube.com##.ytd-primetime-promo-renderer
+youtube.com##ytd-popup-container
-youtube.com##ytd-popup-container
youtube.com##ytd-popup-container
is the filter for ANY popup functions on youtube, user initiated or loaded automatically so that is way to generic. There are old issues (https://github.com/yourduskquibbles/webannoyances/issues/16) from couple years ago on this repository about that.
Could do a :has-text(foo)
for the upsell but then you don't get matches for other languages. Just given the class name of upsell
though I think this is always going to be for some purpose to try and get user to subscribe to youtubeTV or go "premium".
Hello, I'm having the same problem as described in this issue, only for me the login prompt is not shown in a popup. The login prompt is shown instead of the video in the video container.
Here's a screenshot, though I probably shouldn't have cropped it: https://imgur.com/a/4Q6B158
I hope it's alright to put this here instead of creating a new issues since it's essetianlly the same issue.
@randomcookiemonster I've never seen that login wall before. What setup are you using when you see this? e.g. Is it only on chrome or mobile? In private mode with cookies blocked? More details would be good as I have never seen this one before on standard US IP
Unfortunately, only way for others to help is if it is recreatable.
I once saw a similar one on blocked materials when a subscription is not paid for YouTuber.
@randomcookiemonster I've never seen that login wall before. What setup are you using when you see this? e.g. Is it only on chrome or mobile? In private mode with cookies blocked? More details would be good as I have never seen this one before on standard US IP
Unfortunately, only way for others to help is if it is recreatable.
I've never seen anything like it before either, It feels like Youtube is testing something new.
My setup:
I once saw a similar one on blocked materials when a subscription is not paid for YouTuber.
Good idea, but im my case I don't think this is the case. None of the channels I've watched videos from require a subscription. The video will also play after I click "NOT NOW".
standard residential US IP? No vpn/proxy?
standard residential US IP? No vpn/proxy?
Sorry, forgot that part. I'm using a standard Swedish IP, No vpn or proxy.
A possibly related problem that started at the same time is that, whenever the login prompt isn't shown, videos will start playing, the page reloads after a second, and the video doesn't play automatically this time. Maybe the prompt can't be shown and it forces a page reload?
Swedish IP
I can only reproduce too high buttons:
touch version on PC without touch | normal |
Swedish IP
[edit: removed images]
I'm not sure what you mean, I haven't mentioned any buttons?
play bar:
Swedish A/B test | normal |
This combination of network and cosmetic filters blocks the signin wall for me on https://youtu.be/jXsdKpOWL1U?t=8
using Swedish VPN
||youtube.com/*jsbin/spf.vflset/*$script,domain=youtube.com
||youtube.com/notifications_ajax?action_get_registration_token=1$xhr,domain=youtube.com
||consent.google.com^$subdocument,domain=youtube.com
||google.com/js/bg/$script,domain=youtube.com
||youtube.com/youtubei/v1/log_event$xhr,domain=youtube.com
youtube.com##.opened
youtube.com###consent-bump
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
@randomcookiemonster and @krystian3w can you test? It also still allowed me to login if i wanted to with Sign in
button.
Edit: it doesn't start the video at timestamp requested but does an initial load then a sub reload? video is at least watchable without clicking through popups though?
Edit 2: With https://youtu.be/jXsdKpOWL1U?t=8
URL given by youtube (right click video, copy video URL at current timestamp), the video starts at correct timestamp when loaded in new container.
||youtube.com/*jsbin/spf.vflset/*$script,domain=youtube.com ||youtube.com/notifications_ajax?action_get_registration_token=1$xhr,domain=youtube.com ||consent.google.com^$subdocument,domain=youtube.com ||google.com/js/bg/$script,domain=youtube.com ||youtube.com/youtubei/v1/log_event$xhr,domain=youtube.com youtube.com##.opened youtube.com###consent-bump youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
Thank you I will test this, might take a while to be sure it works.
Do I add everything to "My Filters"?
Edit: it doesn't start the video at timestamp requested but does an initial load then a sub reload? video is at least watchable without clicking through popups though?
Sorry I'm not sure what you mean by this?
Edit: Oh, the filters reloads the page?
Do I add everything to "My Filters"?
yes.
youtube.com##.opened
no needed, you added in the past: ##iron-overlay-backdrop
Sorry I'm not sure what you mean by this?
Also I don't understand, filters break e.g. https://www.youtube.com/watch?v=jXsdKpOWL1U?t=8
Also I don't understand, filters break e.g.
https://www.youtube.com/watch?v=jXsdKpOWL1U?t=8
I think that's what he said.
Edit: it doesn't start the video at timestamp requested but does an initial load then a sub reload? video is at least watchable without clicking through popups though?
Sorry I'm not sure what you mean by this?
Edit: Oh, the filters reloads the page?
If my assumption is correct, which filter is responsible for discarding the "t"-param (and probably all params?)?
||youtube.com/*jsbin/spf.vflset/*$script,domain=youtube.com ||youtube.com/notifications_ajax?action_get_registration_token=1$xhr,domain=youtube.com ||consent.google.com^$subdocument,domain=youtube.com ||google.com/js/bg/$script,domain=youtube.com ||youtube.com/youtubei/v1/log_event$xhr,domain=youtube.com youtube.com##.opened youtube.com###consent-bump youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
@randomcookiemonster and @krystian3w can you test? It also still allowed me to login if i wanted to with
Sign in
button.@yourduskquibbles Unfortunately this doesn't stop the login prompt.
I suppose these break timers from comments or description video: 1:08
/ 1:32:15
I think the signin popup script code is being loaded through https://www.youtube.com/s/desktop/5068772e/jsbin/desktop_polymer_inlined_html_polymer_flags.vflset/desktop_polymer_inlined_html_polymer_flags.js
You can use ctrl + f and search for Polymer({is:"ytd-consent-bump-renderer"
to find in source but I don't know enough js/script defusers to know if it is able to be defused though?
I was able to reproduce with Polish VPN, youtube.com###dialog
works.
There are two login blocks that I've seen from testing with EU VPNs
youtube.com##.opened
youtube.com###consent-bump
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
+js()
type filter would be needed to work around this one. I can't always recreate this wall so it is hard to do a lot of testing on it, but it is the login wall that turns the video player grey reported by @randomcookiemonster above@yourduskquibbles These work for me
youtube.com##ytd-popup-container
youtube.com###consent-bump
youtube.com##ytd-popup-container
will break all user-initiated clicks that pop open a modal such as login
& save
. It's too generic it is how youtube loads all of their automatic and user-generated popup elements.
Hmmm, welll I tried with the Swedish IP and I can't reproduce the black overlay over the player.
Hmmm, welll I tried with the Swedish IP and I can't reproduce the black overlay over the player.
I don't even think it is an overlay with the Swedish IP wall, it is the video
player element itself. The page gets redrawn about 2 seconds into a video and that is what gets displayed in place of the video. (Probably as the JS code gets stepped through in the browser) Then once you click not now or sign in, the page gets redrawn again. My guess is that setting some boolean constant that drives the A/B login-required to a false
would nuke it
youtube.com###consent-bump
- GDPR by Google:
or at any time go to
g.co/privacytools
.
youtube.com###dialog
- cut only right part of pop-up and possible leftover left oldie "keyhole":
youtube.com###consent-bump
- GDPR by Google:or at any time go to
g.co/privacytools
.
youtube.com###dialog
- cut only right part of pop-up and possible leftover left oldie "keyhole":
Do just these filters three fix the Polish Login Wall
?
youtube.com##.opened
youtube.com###consent-bump
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
Not 3 but 2:
youtube.com##.opened
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
I think that as long as they do not block the rewind (scroll), maybe Fanboy Annoyance should also cut it out.
So youtube.com###consent-bump
should NOT be added to modal_filters.txt
list but other two are safe to add?
If you're see leaking pop-ups about cookies and ad personalization policy (###consent-bump
), maybe add it to cookie_filters.txt
.
And if you are not logged in and want to remove a frozen player, you can try to use it:
cookie_filters.txt
:
youtube.com###consent-bump:remove()
modal_filters.txt
:
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer:remove()
youtube.com##.opened:remove()
I have the impression that at the time, Google is not detecting that the pop-up was and the player is not stopping.
Marking as partially solved since I have no fix for Swedish Login Wall
I still (intermittently) get the prompt with the following rules:
youtube.com##.opened
youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer
Try after update from https://github.com/yourduskquibbles/webannoyances/commit/c384322052e8c0497f38963ccd46defc783e9c5d
this no have filter solution for now: https://i.imgur.com/3NPYoNd.png
https://i.imgur.com/3NPYoNd.png is the prompt I get.
Thank you.
It's either https://user-images.githubusercontent.com/10229320/91622121-5649c080-e99e-11ea-8c88-7fdf11c7dbe9.png or https://i.imgur.com/3NPYoNd.png.
If I understand you correctly, there's no solution currently for both.
Yes, because the tests with the network filters was failed and that black box over the player is still visible.
URL(s) where the issue occurs
youtube.com
Describe the issue
Pop-up with new (?) string "
Sign in to YouTube
". It may appear at the first visit or after some time.No have match into your regex: https://github.com/yourduskquibbles/webannoyances/blob/024c8dca77994fb6dad1d9576efac283ef40379c/filters/modal_filters.txt#L996-L998
Screenshot(s)
Versions
Settings
Notes
Maybe more globe range is use:
:has(a[href^="https://support.google.com/youtube/?p=sign_in"])
youtube.com##ytd-popup-container > paper-dialog.ytd-popup-container[role="dialog"]:has(a[href^="https://support.google.com/youtube/?p=sign_in"])
Pop-up may use same background as cookie/rules policy: