Add Night cooling registers

[johanschelin]

Added support for Night cooling

[codecov[bot]]

Codecov Report

Patch and project coverage have no change.

Comparison is base (440567e) 56.84% compared to head (43b6127) 56.84%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #113 +/- ## ======================================= Coverage 56.84% 56.84% ======================================= Files 14 14 Lines 1154 1154 ======================================= Hits 656 656 Misses 498 498 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[elupus]

Can you also run the script that update the json file?

[johanschelin]

If you just tell me how - I can do it- And then I will know for future PRs as well.

Med vänlig hälsning, Johan Schelin

---

Från: Joakim Plate @.> Skickat: Wednesday, September 13, 2023 9:11:01 PM Till: yozik04/nibe @.> Kopia: Johan Schelin @.>; Author @.> Ämne: Re: [yozik04/nibe] Update s1155_s1255.csv (PR #113)

Can you also run the script that update the json file?

— Reply to this email directly, view it on GitHubhttps://github.com/yozik04/nibe/pull/113#issuecomment-1718174019, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APTUQJTZ7GIDQ6BKJEWKUVLX2IAMLANCNFSM6AAAAAA4SA4O7I. You are receiving this because you authored the thread.Message ID: @.***>

[yozik04]

@johanschelin Did you manually wrote these lines or you exported from the unit? I have run our script and it failed to convert.

To update json file we have a script:

python3 -m nibe.console_scripts.convert_csv

[johanschelin]

I exported to CSV from the pump and then pasted the three lines. Can double check to see what could be wrong.

Has done it once before and it worked fine.

I’ll check and come back

Med vänlig hälsning, Johan Schelin

---

Från: Jevgeni Kiski @.> Skickat: Thursday, September 14, 2023 12:48:41 PM Till: yozik04/nibe @.> Kopia: Johan Schelin @.>; Mention @.> Ämne: Re: [yozik04/nibe] Update s1155_s1255.csv (PR #113)

@johanschelinhttps://github.com/johanschelin Did you manually wrote these lines or you exported from the unit? I have run our script and it failed to convert.

To update json file we have a script:

python3 -m nibe.console_scripts.convert_csv

— Reply to this email directly, view it on GitHubhttps://github.com/yozik04/nibe/pull/113#issuecomment-1719218088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APTUQJSBUHCLPQEQMOI6JHTX2LOITANCNFSM6AAAAAA4SA4O7I. You are receiving this because you were mentioned.Message ID: @.***>

[johanschelin]

Found a tab in the row directly above that probably got affected when I pasted the new rows. Have added that to the PR. Can you see if the script for json-conversion works now? Tried to run the conversion tool myself but obviously lack some knowledge – succeeded almost – but get a bunch of errors when converting.

From: Jevgeni Kiski @.> Sent: 14 September 2023 12:49 To: yozik04/nibe @.> Cc: Johan Schelin @.>; Mention @.> Subject: Re: [yozik04/nibe] Update s1155_s1255.csv (PR #113)

@johanschelinhttps://github.com/johanschelin Did you manually wrote these lines or you exported from the unit? I have run our script and it failed to convert.

To update json file we have a script:

python3 -m nibe.console_scripts.convert_csv

— Reply to this email directly, view it on GitHubhttps://github.com/yozik04/nibe/pull/113#issuecomment-1719218088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APTUQJSBUHCLPQEQMOI6JHTX2LOITANCNFSM6AAAAAA4SA4O7I. You are receiving this because you were mentioned.Message ID: @.**@.>>

[yozik04]

@johanschelin Thank you!

[johanschelin]

Will you create a PR for this to be pulled into the core for 2023.10?

[elupus]

I will when i get a chance. Feel free to do it if you have the time.

[johanschelin]

I am learning but not completely sure of the process for merging to core, do YOU need to make a new release of the master branch first, before I can create a PR from that one?

---

Från: Joakim Plate @.> Skickat: den 30 september 2023 13:47 Till: yozik04/nibe @.> Kopia: Johan Schelin @.>; Mention @.> Ämne: Re: [yozik04/nibe] Add Night cooling registers (PR #113)

I will when i get a chance. Feel free to do it if you have the time.

— Reply to this email directly, view it on GitHubhttps://github.com/yozik04/nibe/pull/113#issuecomment-1741748247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APTUQJSFRP3TEL7EUUX5H43X5ABF3ANCNFSM6AAAAAA4SA4O7I. You are receiving this because you were mentioned.Message ID: @.***>

[yozik04]

I have released 2.4.0 to PyPi. So we need to bump version in HA core.