yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Make sure read does not leak decode error #115

Closed elupus closed 9 months ago

elupus commented 9 months ago

Leaking DecodeException from read_coil, causes accumulation of read faults to fail in read_coils.

See https://github.com/home-assistant/core/issues/100852 for some reference on how this disables all reads from device.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c6f2fdc) 56.84% compared to head (032780d) 57.09%.

:exclamation: Current head 032780d differs from pull request most recent head a42e138. Consider uploading reports for the commit a42e138 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #115 +/- ## ========================================== + Coverage 56.84% 57.09% +0.24% ========================================== Files 14 14 Lines 1154 1156 +2 ========================================== + Hits 656 660 +4 + Misses 498 496 -2 ``` | [Files](https://app.codecov.io/gh/yozik04/nibe/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jevgeni+Kiski) | Coverage Δ | | |---|---|---| | [nibe/connection/modbus.py](https://app.codecov.io/gh/yozik04/nibe/pull/115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jevgeni+Kiski#diff-bmliZS9jb25uZWN0aW9uL21vZGJ1cy5weQ==) | `79.38% <100.00%> (+2.53%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.