yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Make sure validation error also is a readexception #127

Closed elupus closed 8 months ago

elupus commented 8 months ago

These occur if mapping is out of range, and can be handled as partial exceptions in read_coils

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (43f3f45) 57.43% compared to head (dcdf02a) 57.43%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #127 +/- ## ======================================= Coverage 57.43% 57.43% ======================================= Files 14 14 Lines 1177 1177 ======================================= Hits 676 676 Misses 501 501 ``` | [Files](https://app.codecov.io/gh/yozik04/nibe/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jevgeni+Kiski) | Coverage Δ | | |---|---|---| | [nibe/connection/modbus.py](https://app.codecov.io/gh/yozik04/nibe/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jevgeni+Kiski#diff-bmliZS9jb25uZWN0aW9uL21vZGJ1cy5weQ==) | `79.38% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.