search

yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Allow numpy int16 in decode #132

Closed elupus closed 7 months ago

elupus commented 7 months ago

Sometimes umodbus returns a numpy int16 instead of real python ints, so let the decode function explicitly only require an int:able type and wrap it in an int conversion.

Fixes: #131

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ba0e25e) 58.26% compared to head (5a5f295) 58.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #132 +/- ## ======================================= Coverage 58.26% 58.26% ======================================= Files 14 14 Lines 1198 1198 ======================================= Hits 698 698 Misses 500 500 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elupus commented 7 months ago

Thanks!

yozik04 commented 7 months ago

I released it as well, I do not know if you noticed.

elupus commented 7 months ago

I noticed. We had some weird issue that our tests should have caught fixed in #135.

Also seem to be some weirdness with negative numbers still.