yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Correct parsing of RMU data fields #145

Closed elupus closed 6 months ago

elupus commented 6 months ago
codecov[bot] commented 6 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3eb7b88) 57.46% compared to head (c109a85) 57.72%.

Files Patch % Lines
nibe/connection/nibegw.py 76.47% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #145 +/- ## ========================================== + Coverage 57.46% 57.72% +0.26% ========================================== Files 14 14 Lines 1213 1230 +17 ========================================== + Hits 697 710 +13 - Misses 516 520 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yozik04 commented 6 months ago

Do you want to cover encode as well with a test?

elupus commented 6 months ago

Yes probably. Will look at it. I think some back to back roundtrip testing of decode/encode would be enough there.