search

yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Updated S1155/S1255 data from S1155+ECS (pump fw version 2.23.4) #147

Closed geekuality closed 5 months ago

geekuality commented 5 months ago

Updated registers with missing ECS ("climate system 2") data (that is still not listed in any Nibe documentation that I could find, I originally got them by asking Nibe's Finnish service department via email).

CSV generated by the pump: modbus_addresses_all_20240119-06544323025004-1.csv

geekuality commented 5 months ago

I wasn't quite sure how to handle registers that had different address in the source CSV vs my file directly from the pump. Decided to merge all changes and additions, so several unnamed (id:xxxx) registers' addresses were updated in CSV and in addition five named registers were changed in CSV and also changed the JSON. 🤷‍♀️

An example of changed address: https://github.com/yozik04/nibe/pull/147/files#diff-9d9d8a95e5230942a723af84ba4c7ad95225c95d9a25f88987160fe168a1d962L912-R925

yozik04 commented 5 months ago

Did you generate JSON or you have manually edited?

geekuality commented 5 months ago

Generated. (While I was at it, I am just finishing another PR for improvements in extensions and the generation script. 😄 )

yozik04 commented 5 months ago

Do you want me to merge this one or there will be improvements?

geekuality commented 5 months ago

Oh, this one is fine by me. :)

geekuality commented 5 months ago

... As in, go ahead with merge. 😆

yozik04 commented 5 months ago

Thank you!