search

yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Support parsing 32 bit values log set #149

Closed elupus closed 5 months ago

elupus commented 5 months ago

The log set data for 32 bit values seem to come with a "virtual" address at the next index from the data. So re-combine the data at reception.

elupus commented 5 months ago

I don't yet have a full raw log of data on this. So not fully tested yet. Do you happen to have one @yozik04 when you looked at this for mqtt branch?

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3eb7b88) 57.46% compared to head (262d64d) 57.84%. Report is 11 commits behind head on master.

Files Patch % Lines
nibe/connection/nibegw.py 86.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #149 +/- ## ========================================== + Coverage 57.46% 57.84% +0.38% ========================================== Files 14 14 Lines 1213 1243 +30 ========================================== + Hits 697 719 +22 - Misses 516 524 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yozik04 commented 5 months ago

I intentionally changed to pick only 16bit parameters on my heat pump. I do not have a raw log for that.

elupus commented 5 months ago

Feeling quite confident this should be alright. Found a user log at https://github.com/home-assistant/core/issues/84497 and added case for that. The parsed value looks quite alright. The number of compressor starts somewhat high, perhaps the accumulated kwh too high, but i think that value might have wrong scaling in the database.

yozik04 commented 5 months ago

I verified it. Seems to be correct.