search

yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Invalid values slip through #160

Open yozik04 opened 1 month ago

yozik04 commented 1 month ago

Unfortunately we have a regression that now invalid values slip into HomeAssistant:

NibeGw, register address 40016 (EB100-EP14-BT11 Brine Out Temp). Which is signed 16bit. image

yozik04 commented 1 month ago

Hmm:

Int16sl.parse(b'\x00\x80')
-32768

Int16sl.parse(b'\x01\x80')
-32767
yozik04 commented 1 month ago

I see that at the same time other values were also read wrong. image

I think we should add some checks and discard whole received packet if any of the values are not invalid. I have no idea how it manages to bypass checksum check. I see this happen from time to time. Noticed second time this week.

elupus commented 1 month ago

Looks quite weird. I wonder how we could detect that case.