search

yozik04 / nibe

Library for communication with Nibe heatpumps.
GNU General Public License v3.0
42 stars 31 forks source link

Catch incomplete read and log which coil failed #162

Closed elupus closed 3 weeks ago

elupus commented 3 weeks ago

This should allow easier fault tracing of issues with pumps crashing

See: https://github.com/home-assistant/core/issues/118598

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.96%. Comparing base (7a4c599) to head (e6e8b15). Report is 15 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #162 +/- ## ========================================== + Coverage 57.84% 57.96% +0.12% ========================================== Files 14 14 Lines 1243 1261 +18 ========================================== + Hits 719 731 +12 - Misses 524 530 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elupus commented 3 weeks ago

Ps. I noticed we do retries in the modbus connection. I wonder if that make sense there?

yozik04 commented 3 weeks ago

@elupus If you want to make a release please do it yourself. Bump app version in __init__.py and make a release with the same version. I am away from computer for couple weeks. 😄

yozik04 commented 3 weeks ago

Ps. I noticed we do retries in the modbus connection. I wonder if that make sense there?

TCP can still fail. I think it is fine.

elupus commented 3 weeks ago

Will do. Right, forgot modbus reconnects by itself in the background. I wonder if that will hide the exception i'm looking for.