search

ytgov / yukon-ca

New version of Yukon.ca, built on Drupal 10
1 stars 3 forks source link

[P-1] Facilities listings are missing #247

Open ew-andrew-sus opened 11 months ago

ew-andrew-sus commented 11 months ago

Description: A number of pages, such as “Find a school”, make use of a view that lists Places of certain types.

D7: https://yukon.ca/en/education-and-schools/kindergarten-grade-12/find-school

In D7, this block is facilities_listing_blocks, it has 18 displays (pages/blocks).

Some other pages that include these views (all D7):

https://yukon.ca/en/driving-and-transportation/airports-and-aerodromes/find-airport-or-aerodrome https://yukon.ca/en/health-and-wellness/find-hospital-or-health-centre https://yukon.ca/en/long-term-care-homes https://yukon.ca/en/arts-and-culture/museums-and-public-collections/public-art-locations https://yukon.ca/en/driving-and-transportation/travel-yukon/find-visitor-information-centre

Task: FIx Facilities listing migration

Deliverable: Facilities listings should exist on D10 like on D7

w3creatives commented 1 month ago

Most of the things were missing for this functionality:

1) We have created a new taxonomy "School Board Type" 2) Added Migration for School Board type - yukon_migrate_school_board_type 3) Created a School board type field in the education facilities paragraph. 4) Update the migration of the - yukon_migrate_education_facilities 5) Created a view as a block for that and assigned the same to the pages.

Reference Links:

1) https://yukon-new-d10.w3creatives.com/docroot/en/driving-and-transportation/airports-and-aerodromes/find-airport-or-aerodrome 2) https://yukon-new-d10.w3creatives.com/docroot/en/health-and-wellness/care-services/find-hospital-or-health-centre 3) https://yukon-new-d10.w3creatives.com/docroot/en/health-and-wellness/care-services/continuing-care-facilities 4) https://yukon-new-d10.w3creatives.com/docroot/en/arts-and-culture/museums-and-public-collections/public-art-locations 5) https://yukon-new-d10.w3creatives.com/docroot/en/driving-and-transportation/travel-yukon/find-visitor-information-centre 6) https://yukon-new-d10.w3creatives.com/docroot/en/education-and-schools/plan-elementary-and-high-school/find-school

leeomara commented 1 month ago

I see this working correctly on W3 Creatives test server.

On UAT, no places are listed.

e.g. All 3 school board types list "No results found". The School board taxonomy is there, as are terms. Places migration seems good, as I can find specific schools. However, the view is not finding them.

Screenshot 2024-10-15 at 1 56 44 PM

Same with Find an airport or aerodrome, Find a hospital or health centre, Long-term care homes, Public art locations, Find a visitor information centre. All show "No results found."

w3creatives commented 3 weeks ago

This should be working. We need to access the UAT environment to de-bug it.

leeomara commented 3 weeks ago

This appears related to the similar issue with campgrounds (#257 and #261), where the term filters don't align.

For example, the view facilities_listing_blocks, which has a display for "Yukon Education" (block_19), the two term-based filters have the wrong terms listed:

Those should be:

Related issues:

leeomara commented 3 weeks ago
D7 display (facilities_listing_blocks) D10 version (facilities_listing_blocks)
Hospital ✅
Continuing care ✅
Community care ✅
Cemetery ?
Crematorium ?
College ✅
Commission scolaire francophone du Yukon (CSFY) ✅
Airport ✅
Archive ✅
Community centre ✅
Library ✅
Public art ✅
Tourism info centre ✅
Hazardous waste ✅
Recycling ✅
Solid waste ✅
Visitor information centres ✅
Interpretive centres ✅
First Nation School Board (FNSB) ✅
Yukon Education ✅

D10 also has "School"

leeomara commented 3 weeks ago

Every single of the D10 Facilities displays in UAT have issues with term filters.

w3creatives commented 3 weeks ago

We have updated the migration process and now we will match TID as well during the import. This will save us from any future issues linked to taxonomies. Please check and let us know if any modifications are required. Migration re-run is required.

Linked with:

leeomara commented 3 weeks ago

@w3creatives That's great news. Let me know when the code for this fix ships, so I can re-run the migrations and test.

w3creatives commented 3 weeks ago

Please consider the latest PR:

https://github.com/ytgov/yukon-ca/pull/670

leeomara commented 3 weeks ago

This is much improved, but not quite there yet.

E.g. Archive has a filter

(field_places_record_type: Paragraph) Paragraph: Community facility type (= Takhini Hot Spring Road)

w3creatives commented 3 weeks ago

Please review:

https://yukon-new-d10.w3creatives.com/docroot/en/admin/structure/views/view/facilities_listing_blocks/edit/block_8

lgontard commented 9 hours ago

@leeomara Can you look at this one?