search

ytgov / yukon-ca

New version of Yukon.ca, built on Drupal 10
1 stars 3 forks source link

Issue #142 - French translation does not appear #321

Closed w3creatives closed 8 months ago

w3creatives commented 8 months ago

Issue Addressed: https://github.com/ytgov/yukon-ca/issues/142

Steps:

  1. Merge the PR
  2. Login to Drupal admin
  3. Click Extend on the top admin menu
  4. In the Filter (Input Box), search yukon w3 migrate, check the checkbox and click Install.
  5. After the custom module gets installed, click the link [root-URL]/custom_migrate.
  6. Wait for some time. When done, clear the Drupal cache using drush cr

Notes

This is a custom module that will update the missing translations. If the static function is not acceptable then we can try changing it. But it is used in Drupal core as well:

Drupal Docs

ew-andrew-sus commented 8 months ago

@w3creatives what is the reason not to enable this module by default?

w3creatives commented 8 months ago

This is a custom module that we built for testing and getting the EW/YG approval.

ew-andrew-sus commented 8 months ago

@w3creatives We can't merge changes that cause the build to fail. Because all future builds will fail as well. So fix build issues please

ew-andrew-sus commented 8 months ago

@w3creatives Just my thoughts aloud: Does it work correctly on the rollback process for this custom-migrated content?

w3creatives commented 8 months ago

We believe it should work for Landing Page and Landing Page Level 2, but we need to keep adding the missing translations as we find them during the upcoming phases.