search

yugabyte / yugabyte-db

YugabyteDB - the cloud native distributed SQL database for mission-critical applications.
https://www.yugabyte.com
Other
8.86k stars 1.05k forks source link

[DocDB] backup: Preserve extended file attributes when using rsync #11466

Open bmatican opened 2 years ago

bmatican commented 2 years ago

Jira Link: DB-1076

Description

Adding -X to our rsync commands in yb_backup should be a noop for most systems, but might help avoid some stability issues on storage systems which rely on the extended file attributes.

hulien22 commented 2 years ago

Seems that -X isn't available for all rsync versions? (see https://superuser.com/questions/1429370/rsync-with-x-option-doesnt-work) We could add a flag or enable this, but that would also need to get enabled via platform (feels like platform could benefit from having a text field in backups where you can pass options to the backup script) Alternatively, we can also check the rsync version on each machine before running?