yugabyte / yugabyte-db

YugabyteDB - the cloud native distributed SQL database for mission-critical applications.
https://www.yugabyte.com
Other
8.87k stars 1.05k forks source link

[YugabyteD] [QA] Insufficient System Checks during Start #14883

Open zlareb1-yb opened 1 year ago

zlareb1-yb commented 1 year ago

Description

During start we are just giving (not highlighted) info in Status as - Status command timed out as YugabyteDB "yb-master" process is not responding.

We should fail on System checks itself in such cases

MacBook-Pro-16-inch-2021:yugabyte-2.17.1.0 mzafar$ ./bin/yugabyted start --tserver_rpc_port=0000
Starting yugabyted...
✅ System checks           
✅ YugabyteDB Started                  
⚠ WARNING: Cluster started in an insecure mode without authentication and encryption enabled. For non-production use only, not to be used without firewalls blocking the internet traffic.
✅ UI ready         

+----------------------------------------------------------------------------------------------------------+
|                                                yugabyted                                                 |
+----------------------------------------------------------------------------------------------------------+
| Status              : Status command timed out as YugabyteDB "yb-master" process is not responding.      |
| Replication Factor  : None                                                                               |
| YugabyteDB UI       : http://127.0.0.1:15433                                                             |
| JDBC                : jdbc:postgresql://127.0.0.1:5433/yugabyte?user=yugabyte&password=fF6JlGRCVype      |
| YSQL                : bin/ysqlsh   -U yugabyte -d yugabyte                                               |
| YCQL                : bin/ycqlsh 127.0.0.1 1111 -u cassandra                                             |
| Data Dir            : /Users/mzafar/var/data                                                             |
| Log Dir             : /Users/mzafar/ybd/b                                                                |
| Universe UUID       : f35d38de-1fc6-4615-9f81-0c4f253d92e9                                               |
+----------------------------------------------------------------------------------------------------------+
🚀 YugabyteDB started successfully! To load a sample dataset, try 'yugabyted demo'.
🎉 Join us on Slack at https://www.yugabyte.com/slack
👕 Claim your free t-shirt at https://www.yugabyte.com/community-rewards/
ShikharSahay commented 1 year ago

Not able to replicate this issue. For me it shows "Database failed to start":

shikharsahay@sh-mbp-qg7k0 yugabyte-db % ./bin/yugabyted start --tserver_rpc_port=0000           
Starting yugabyted...
✅ System checks
❌ Database failed to start            
Failed to start tserver yugabyted
For more information, check the logs in /Users/shikharsahay/var/logs
shikharsahay@sh-mbp-qg7k0 yugabyte-db % 

Is this behaviour expected or should system checks show failed in this case instead?