search

yugabyte / yugabyte-db

YugabyteDB - the cloud native distributed SQL database for mission-critical applications.
https://www.yugabyte.com
Other
8.84k stars 1.05k forks source link

[DocDB] Improve linter/ find tool that enforces common style guidelines in code #16852

Open pkj415 opened 1 year ago

pkj415 commented 1 year ago

Jira Link: DB-6199

Description

For example, our linter today doesn't enforce https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes.

Instead of the reviewer and developer spending time on adding and addressing such comments, check if a linter/ other tool can catch such things.

Warning: Please confirm that this issue does not contain any sensitive information

hari90 commented 1 year ago

The problem is that we have some amount of broken header linkage, so the order of include matters today. We need to fix that too.