yugabyte / yugabyte-db

YugabyteDB - the cloud native distributed SQL database for mission-critical applications.
https://www.yugabyte.com
Other
8.78k stars 1.05k forks source link

YBC Tests: Fix TS Web access retry loop in YBC #22494

Open OlegLoginov opened 3 months ago

OlegLoginov commented 3 months ago

Jira Link: DB-11420

Description

Fix the tests:

YB_DISABLE_MINICLUSTER_BACKUP_TESTS=0 YB_TEST_YB_CONTROLLER=1  ./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestBackupWithoutTSWebUI

YB_DISABLE_MINICLUSTER_BACKUP_TESTS=0 YB_TEST_YB_CONTROLLER=1  ./yb_build.sh --cxx-test integration-tests_cql-backup-test --gtest_filter CqlBackupTest.TestBackupRestoreWithoutTSWebUI

YBC is loading TS config via TS HTTP UI endpoint: <ts-ip>/varz. In these 2 tests we stop&start this HTTP server, so YBC should do retries during the endpoint accessing. Locally the tests work fine, but in Jenkins environment YBC cannot get the TS config.

It should be fixed in YBC - try to increase number of retries and/or timeout: Hardcoded timeout = 1 sec in ServerConfig():

 ControllerStatus status = EasyCurlGet(url, 1000, data);

Hardcoded number of retries in EasyCurlGet():

int retries = 5;

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

OlegLoginov commented 3 months ago

Original issue: https://github.com/yugabyte/yugabyte-db/issues/21689