yugabyte / yugabyte-db

YugabyteDB - the cloud native distributed SQL database for mission-critical applications.
https://www.yugabyte.com
Other
8.79k stars 1.05k forks source link

[YEDIS] Add support for CLIENT command #985

Open Negashev opened 5 years ago

Negashev commented 5 years ago

CLIENT command in YEDIS not exist

kmuthukk commented 5 years ago

hi @Negashev

Yes - this is not yet implemented. Could you share a little bit more about your use case for the CLIENT command? Is it a existing app or new application or you are using through some other framework (like Spring) and it happens to use the CLIENT * commands?

Are you looking for support for all of these commands, or some specific subset?

CLIENT GETNAME
CLIENT ID
CLIENT KILL
CLIENT LIST
CLIENT PAUSE
CLIENT REPLY
CLIENT SETNAME
CLIENT UNBLOCK

This will give us some helpful context on best next steps, scope of the work, or suggestions for using an alternate approach.

regards, Kannan

Negashev commented 5 years ago

@kmuthukk First is

CLIENT GETNAME
CLIENT SETNAME

next

CLIENT ID
CLIENT LIST
kmuthukk commented 5 years ago

hi @Negashev - could you elaborate on the use case for this a bit more? Do you need this mainly for debuggability?

Negashev commented 5 years ago

@kmuthukk It's dependency on sidekiq, client connect to redis pub/sub and use command CLIENT

kmuthukk commented 5 years ago

I see. Thanks a lot. That's helpful to know.

Does it also use the CLIENT ID and CLIENT LIST commands, or only CLIENT GETNAME/SETNAME commands?

Negashev commented 5 years ago

@kmuthukk Yes! Found solution, turn off client call from application

kmuthukk commented 5 years ago

Nice.

Did you mean: Found solution (and not Find solution)? So sidekick allows you to turn it off?

mysticaltech commented 5 years ago

@Negashev So can you confirm that Sidekiq works with YugaByte? And how do you turn the client command off? This would be revolutionary for Ruby on Rails applications because you could theoretically replace both Postgres and Redis by one YugaByte cluster!

Negashev commented 5 years ago

@mysticaltech So far I have failed, many dependencies, for example, the sscan key is needed further

devthejo commented 3 years ago

Need this too, to make it work with RedisUI related to https://github.com/patrikx3/redis-ui/issues/57