Lack of "Charging finished" status

yurtemre7 / mouse-battery

Get your mouse battery level in a windows system tray icon

MIT License

13 stars 1 forks source link

Lack of "Charging finished" status #7

Open bossman90 opened 3 months ago

bossman90 commented 3 months ago

Looks really good! One thing to consider is to add "charging finished" feature to know when you can unplug the mouse. I've noticed that my mouse can't be charged to 100% but 95% - that's why I've changed the code to:

if battery_level is not None and battery_level == 95 and battery_charging is True:
        draw.rectangle((0, 100 - battery_level, 100, 100), fill="purple")

yurtemre7 commented 3 months ago

I don't know if this is an appropriate change. The next one might say "my mouse doesn't charge till 95%, only 90%". I would say the battery level indicator in the icon (The height of the orange bar when plugged) is enough to tell when to unplug your mouse. If others also want the 95% feature, then OK.