yuvipanda / notebooksharing.space

BSD 3-Clause "New" or "Revised" License
84 stars 10 forks source link

Internal server error if filename contains non-ascii characters #35

Closed astrojuanlu closed 2 years ago

astrojuanlu commented 2 years ago

Thanks so much for nbss, it's so cool! 🚀

I tried uploading a Argüelles.ipynb notebook and got a 5xx error. Renamed it to Arguelles.ipynb, everything is working

yuvipanda commented 2 years ago

Thank you so much for reporting this, @astrojuanlu! Somehow I didn't see this on GitHub...

Looking at the logs, I see:

botocore.exceptions.ParamValidationError: Parameter validation failed:
Non ascii characters found in S3 metadata for key "filename", value: "Argüelles.ipynb".  
S3 metadata can only contain ASCII characters.
yuvipanda commented 2 years ago

This works now! Check out https://notebooksharing.space/view/c62bf62cad5d9a8e1a2038e59a7c74c5097dd11dbc217c13ad3bae2b61362ede#displayOptions=.

Thank you so much for reporting this, @astrojuanlu!