Fix#18 - Added contact.html, about.html, resume.html, portfolio.html and skills.html

[MarkKrutik]

I have added these files but I do not know how to link them to the index,html. May you please give me any suggestions if you have any on to how to do this.

Thank you,

Mark Krutik

[ywpark1]

Thanks @MarkKrutik !

What I meant by separating index.html file was that we have a basic template in index.html, and create new files with different components. For example, the file for 'skills' can include this, not the full html code. :

<div id="skill" class="skill-area">
    <div class="container">
        <div class="row">
            <div class="col-lg-6">
                <div class="skillbar">
                    <h1>My Skills</h1>
                    <p>Lorem ipsum dolor sit amet, ea doming epicuri iudicabit nam, te usu virtute placerat. Purto
                        brute disputando cu est, eam dicam soluta ei. Vel dicam vivendo accusata ei, cum ne
                        periculis molestiae pri. <br> Lorem ipsum dolor sit amet, ea doming epicuri iudicabit nam,
                        te usu virtute placerat. Purto brute disputando cu est.</p>
                    <a href="#" class="btn skill-btn">contact me</a>
                </div>
            </div>
            <div class="col-lg-6">
                <div class="skill-progress">
                    <p>photoshop</p>
                    <div class="progress">
                        <div class="progress-bar" role="progressbar" style="width: 90%" aria-valuenow="90"
                            aria-valuemin="0" aria-valuemax="100">
                            <p>90%</p>
                        </div>
                    </div>
                    <p>illsutrator</p>
                    <div class="progress">
                        <div class="progress-bar" role="progressbar" style="width: 80%" aria-valuenow="80"
                            aria-valuemin="0" aria-valuemax="100">
                            <p>80%</p>
                        </div>
                    </div>
                    <p>html/css</p>
                    <div class="progress">
                        <div class="progress-bar" role="progressbar" style="width: 90%" aria-valuenow="90"
                            aria-valuemin="0" aria-valuemax="100">
                            <p>90%</p>
                        </div>
                    </div>
                    <p>php/mysql</p>
                    <div class="progress">
                        <div class="progress-bar" role="progressbar" style="width: 70%" aria-valuenow="70"
                            aria-valuemin="0" aria-valuemax="100">
                            <p>70%</p>
                        </div>
                    </div>
                </div>
            </div>
            <!--End of col lg 6-->
        </div>
        <!--End of row-->
    </div>
    <!--End of container-->
</div>

Can you update this? You can add placeholder, such as '{SKILLS}', in the index.html file.

Also, for the travis part, can you create another PR and add files in it? I think it would be better to separate it from html template PR.

[MarkKrutik]

Sure no problem I will do so.

On Tue, Nov 20, 2018, 7:06 PM ywpark1 <notifications@github.com wrote:

Thanks @MarkKrutik https://github.com/MarkKrutik !

What I meant by separating index.html file was that we have a basic template in index.html, and create new files with different components. For example, the file for 'skills' can include this, not the full html code. :

My Skills

Lorem ipsum dolor sit amet, ea doming epicuri iudicabit nam, te usu virtute placerat. Purto brute disputando cu est, eam dicam soluta ei. Vel dicam vivendo accusata ei, cum ne periculis molestiae pri.
Lorem ipsum dolor sit amet, ea doming epicuri iudicabit nam, te usu virtute placerat. Purto brute disputando cu est.

contact me

photoshop

90%

illsutrator

80%

html/css

90%

php/mysql

70%

        </div>
        <!--End of col lg 6-->
    </div>
    <!--End of row-->
</div>
<!--End of container-->

Can you update this? You can add placeholder, such as '{SKILLS}', in the index.html file.

Also, for the travis part, can you create another PR and add files in it? I think it would be better to separate it from html template PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ywpark1/portfolio-generator/pull/19#issuecomment-440475510, or mute the thread https://github.com/notifications/unsubscribe-auth/Ai393aIMsQoWwd4nBwEKeXfnadpkD820ks5uxJjzgaJpZM4YnGoG .