zanza00 / random-theme-switcher

a Visual Studio Code extension that chooses a theme for you
https://marketplace.visualstudio.com/items?itemName=zanza00.random-theme-switcher
8 stars 0 forks source link

Prevented theme swap at startup in daily mode #20

Closed ghost closed 4 years ago

ghost commented 4 years ago

Based on what we said on the issue #19: I added a note about it and fixed the randomThemeSwitcher.switchMode "daily", because even when set themes were swapped at startup.

Happy new year ! πŸ₯‚πŸΎπŸŽ‰πŸŽŠ

ghost commented 4 years ago

Good evening !

I have also added a new feature: Detect when the theme changes and if ! present ask for adding it. I refactored a bit the already present code and i think it's a good result.

The only drawback is that it's not workspace friendly: if you keep a local randomThemeSwitcher.themeList it will ask user to add a theme even if it's already in the %appdata%/Code/User/settings.json because it reads from the /workspaceFolder/.vscode/settings.json but write into the %appdata%/Code/User/settings.json (i.e. it will left the former untouched). But this is not a big issue.

ghost commented 4 years ago

Thank you for the invitation ! ❀ It's a real honor to be part of this !

Ok, i made a commit reflecting the changes. Now, i can go to sleep πŸ˜… Good evening ! 😊✌🏼

zanza00 commented 4 years ago

@Denis-net welcome on board :)