zblurx / dploot

DPAPI looting remotely and locally in Python
MIT License
410 stars 55 forks source link

CryptographyDeprecationWarning: Use PrivateKeyTypes Instead #14

Closed Arszilla closed 7 months ago

Arszilla commented 7 months ago

Hey @zblurx,

While packaging dploot for Kali Linux, I discovered the following warning:

$ dploot -h
/usr/lib/python3/dist-packages/dploot/triage/certificates.py:12: CryptographyDeprecationWarning: Use PrivateKeyTypes instead
  from cryptography.hazmat.primitives.asymmetric.types import PRIVATE_KEY_TYPES
usage: dploot [-h] [-debug] [-quiet]
              {certificates,credentials,masterkeys,vaults,backupkey,rdg,triage,machinemasterkeys,machinecredentials,machinevaults,machinecertificates,machinetriage,browser,wifi}
              ...

DPAPI looting remotely in Python

[...]

If this warning could be addressed and released as v2.1.5, it'd be great, and I'd sincerely appreciate it.

Thanks in advance.

zblurx commented 7 months ago

Hey @Arszilla, the actual version of dploot is 2.6.0 and the issue is fixed in the actual version. I can release a binary for 2.2.5 if you need.

Arszilla commented 7 months ago

Hey @zblurx,

Then would it be possible to release the 2.2.5 tag, as the drafted package is packaged and is using the 2.1.4 tag.

That way, the package can be updated easily and the newer version is published with a tag.

zblurx commented 7 months ago

Here is the release for 2.6.0 with a working binary : https://github.com/zblurx/dploot/releases/tag/2.6.0.

I let you close the issue if it is good for you !

Arszilla commented 7 months ago

@zblurx One issue I see is your README.md. It says/mentions Tamas Jos. I assume that's a typo?

Copyright (c) 2018 Tamas Jos

zblurx commented 7 months ago

Haha I had copy pasted the license text stupidly. Fixed now

Arszilla commented 7 months ago

Haha I had copy pasted the license text stupidly. Fixed now

Just what I suspected :) Be sure to reflect it to the tags. Then I'll test it locally and close this issue and publish the new upstream package so the Kali Team can take a look when they can.

zblurx commented 7 months ago

I just repushed the 2.6.0 release.

Arszilla commented 7 months ago

Everything seems to work fine. I've pushed/published 2.6.0 to GitLab: https://gitlab.com/arszilla/dploot

Thanks a bunch, @zblurx!