zeebe-io / zeebe-performance-test

1 stars 0 forks source link

Fix the endpoint to query prometheus and query retries if data not available in measure.sh #7 #12

Closed rodrigo-lourenco-lopes closed 1 year ago

rodrigo-lourenco-lopes commented 1 year ago

Currently in the CI pipeline the measure.sh was failing constantly due to the endpoint where we query the Prometheus data had been changed, but not updated in this script.

Waiting for minimal throughput
jq: error (at <stdin>:0): null (null) cannot be parsed as a number
Error: Process completed with exit code 5.
The error that we find in this script is that we are trying to parse a null value, the request-response body in this case.

Also before the change of the endpoint, there were some occasional runs where the script would fail randomly probably due to a race condition of the query happening before the data being available right after the creation of the benchmark.

One solution could be to increase the sleep timer before this request happens. Another one that was used here is to retry the endpoint until the request-response body is no longer null.

Closes https://github.com/zeebe-io/zeebe-performance-test/issues/7

rodrigo-lourenco-lopes commented 1 year ago

cloud auth print-access-token line at the top of the script 👍

No need for another review though

Ups! Good catch! :)