Closed tfnribeiro closed 6 months ago
Name | Link |
---|---|
Latest commit | c19fac653f8ea78a5ea1994d82ab8463f7e79e35 |
Latest deploy log | https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/65b9332e942a7100081c60f3 |
I have added the class SessionStorage
to manage the variable AudioExercisesEnabled
. disableAudioExercises
makes a call similiar to the setAudioExercisesEnabled
and setting it to false
. I have to initialized the SessionStorage both at login time but also at the exercise time, as the user might have cached login data.
I am wondering if we can do this in a better way? I initially thought the App.js is always run, but it seems that the variable isn't initialized if I am already logged in.
Tiago, there was a merge conflict that I've merged. I'm very tired though: can you pls. check that it is still correct?
Mircea, I think the api is missing the changes to support the session. I am getting a lot of errors running the branch with the changes.
I see that there is one line in the Exercises.js
that shouldn't be there - should I make a new PR?
yes, send a PR please. and i'll merge also the PR into the API. so then we should have the latest working versions in API>master and WEB>development.
It's late, but when checking the changes after the API update, I am still getting this:
[image: image.png]
On Tue, 30 Jan 2024 at 21:58, Mircea Filip Lungu @.***> wrote:
yes, send a PR please. and i'll merge also the PR into the API. so then we should have the latest working versions in API>master and WEB>development.
— Reply to this email directly, view it on GitHub https://github.com/zeeguu/web/pull/283#issuecomment-1917881815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEVT7E4OG4LCBOPRY473CTYRFNGLAVCNFSM6AAAAABCMIS32GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXHA4DCOBRGU . You are receiving this because you were assigned.Message ID: @.***>
did you try to upload an image? i can't see it.
Added a small button to disable exercises for the session.
This is used for the session and if the user re-opens the tab or the app in another device the setting is reverted back to the default.