search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Update Exercises.js #286

Closed tfnribeiro closed 6 months ago

tfnribeiro commented 6 months ago

Removed uninitialized variable (old variable used to check the audio exercises).

netlify[bot] commented 6 months ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit a189453e0bb56e09a59af02dfaaa46d8135cc1bb
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/65b96e4b8c7929000815bc43
Deploy Preview https://deploy-preview-286--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mircealungu commented 6 months ago

We've broken git :)

there's a merge conflict:

image

when i try to fix it, it looks like this:

image

this means that the current version on the development branch actually does not have those lines. in fact, i remember removing them in the previous merge conflict i've fixed.

are you really really sure that you're looking at the latest version of the zeeguu:development branch?

tfnribeiro commented 6 months ago

I think now it's up-to-date? Maybe it didn't pull the changes when I was looking at it?

mircealungu commented 6 months ago

that would explain it. i feel confident enough that i'll deploy and then go to sleep :)

mircealungu commented 6 months ago

all is well and the new version is on zeeguu.org! the audio silencing works perfectly! and the reading session timer also seems to work. we should keep an eye on these features attentively in the upcoming days!