Redirection modal for unsupported browsers

igawaclawska commented 6 months ago

Pr: 12.02.24

A `RedirectionNotificationForUnsupportedBrowsers.js`

This component contains mobile and desktop versions of the notification and renders them conditionally by running renderHeaderForMobileOrUnsupportedDesktop() and renderBodyForMobileOrUnsupportedDesktop(). The footer and props are the same in both cases. The desktop variant is displayed on all desktop browsers that do not support the Zeeguu Reader browser extension.

The modal has the following functionality:

Allows installation of the supported browsers
The user can download recommended browsers from the links in the modal
Allows adding the article to Saves
Similarly like on mobile devices, the user can save the article and access it internally
Allows entering the article's website
The user can also go to the original source of the article

Future work and consideration

For the supported browsers

Add a condition to RedirectionNotificationForSupportedBrowsers.js that checks if the extension has been installed
If the extension has not been installed, display a dialog that recommends installing it instead of a dialog that shows how to use it. Additionally, on the home page, display a pop-up that recommends the installation of the extension
Check if it is possible (and clean) to implement all variants of redirection notification modals as one component

netlify[bot] commented 6 months ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name	Link
Latest commit	f032ad5e32b17cee09c42c84fc4e5b3997e2719b
Latest deploy log	https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/65e5dcb76ff209000849c77b
Deploy Preview	https://deploy-preview-297--voluble-nougat-015dd1.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mircealungu commented 6 months ago

It looks beautiful, the text is clear.

The code is hard to follow. I wonder if it's because of the many very long identifiers or I'm just tired.

One possible solution could be:

move all the behavior related to this to a separate folder (e.g. /components/redirect_notification)
then, in the context of that folder we can assume that we're talking about the redirect notification, so we don't have to repeat some of the terms so often?

igawaclawska commented 6 months ago

Dear @mircealungu, Thank you for the feedback. I have pushed new updates and addressed your suggestions in the comments above.

igawaclawska commented 5 months ago

Hi @mircealungu , The GoToButton component is ready.

zeeguu / web