search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Match should check if there is duplicate bookmarks #304

Closed tfnribeiro closed 5 months ago

tfnribeiro commented 6 months ago

When a user has translated the same word in different contexts a situation like this can happen:

image

Since the match is done by ID it means in this situation, it's a 50/50 if the user will get it correct.

This could be fixed in 2 ways, either:

  1. Check for the expected translation rather than the ID (which would match for both);
  2. Avoid having 2 repeated bookmarks in the Check exercise.

I would go with the second one.

mircealungu commented 6 months ago

I don't remember seeing that happen!

i think the second is a good choice: avoiding duplicate bookmarks in match. it would have to be the same in all the exercises where we show multiple bookmarks.

one way would be to solve this when we're assigning words to exercise types. another would be to maybe ensure that there are no word/translation duplicates when we schedule words in the API?

tfnribeiro commented 6 months ago

I think the easiest would be to do at the API level, so whenever we do the priority_bookmarks call, we just filter any duplicated words.

However, I think when we call for "similar" bookmarks we don't check for repeated words. So maybe this could be an issue in multiple choice? Rare, but could happen.

mircealungu commented 6 months ago

That should be fine. Should be very rare. And in the future we might move away from a separate call to similar words as suggested in another convo these days!

tfnribeiro commented 6 months ago

Alright! Should I make this as part of the changes to the work schedule? I will add a line that filters out any words that are repeated?

mircealungu commented 6 months ago

Sure! m.

On 19 Feb 2024, at 13.39, Tiago Ribeiro @.***> wrote:

Alright! Should I make this as part of the changes to the work schedule? I will add a line that filters out any words that are repeated?

— Reply to this email directly, view it on GitHub https://github.com/zeeguu/web/issues/304#issuecomment-1952268171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRNBZB4B5HUEC4HIJFBYDYUM2VPAVCNFSM6AAAAABDO7NQQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSGI3DQMJXGE. You are receiving this because you commented.