solution not completely shown?:

zeeguu / web

Frontend for the zeeguu web application.

https://www.zeeguu.org

3 stars 5 forks source link

solution not completely shown?: #320

Closed mircealungu closed 4 months ago

mircealungu commented 4 months ago

Seems that I reliably we don't show the solution of the second exercise type?

merleschoen commented 4 months ago

Yes, I've just pushed the changes where the answer should be checked. I didn't know you were going to look into the code already. :)

tfnribeiro commented 4 months ago

Oh, I haven't seen this before, is this in the new exercises or also in the old ones? Either way, I can check this come Monday.

mircealungu commented 4 months ago

Yes, I've just pushed the changes where the answer should be checked. I didn't know you were going to look into the code already. :)

eheh. sure I keep an eye on everything you do :) srsly, this is not related to your code... and I wasn't aware that you pushed changes. I guess they're on your branch? looking forward to seeing them on Monday. the bug I mention is on the master branch.

@tfnribeiro - Monday is mighty fine! no hurry!

tfnribeiro commented 4 months ago

Found the issue :)

We moved some code to set the IsRendered variable, and since the text rendering update is now under a UseEffect, we need to check if we are in the solution state. That should fix this issue.

mircealungu commented 4 months ago

nice! merged and deployed.