search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

New exercises for passive and active sequences #327

Closed merleschoen closed 2 months ago

merleschoen commented 3 months ago

This pull request contains 6 new exercise types and active and passive sequences with and without audio. The styling of the MultipleChoiceContext exercise doesn't always work as expected, so the orange border isn't always applied when the correct answer is clicked. Unfortunately, I can't really see a pattern. However, it reliably fills the correct solution in the blank, so the user still gets adequate feedback.

netlify[bot] commented 3 months ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit a568bfc2c6ccb78cd7243d36211329df4f97f21d
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/6628dcf12ade420008fbc1d1
Deploy Preview https://deploy-preview-327--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mircealungu commented 2 months ago

how did we get to this? :))

image

ok, let's see what's this about!

mircealungu commented 2 months ago

I can't see the learningCylce icon:

Neither on preview:

image

Nor on my machine:

image
mircealungu commented 2 months ago

This is what I see after I got a word correctly:

image

Would it not be possible to mark with green also in the progress bar the fact that I've got a word right?

It would reinforce the checkmark and would show some... progress on the progress bar :)

image
merleschoen commented 2 months ago

how did we get to this? :)) image

ok, let's see what's this about!

I can see that when we updated my branch with the latest changes, Tiago's changes were somehow included in my pr. Also, the flag emojis are quite a few files :)

merleschoen commented 2 months ago

This is what I see after I got a word correctly:

image

Would it not be possible to mark with green also in the progress bar the fact that I've got a word right?

It would reinforce the checkmark and would show some... progress on the progress bar :)

image

Something is not right. It does update the color to green on my machine.

mircealungu commented 2 months ago

Something is not right. It does update the color to green on my machine.

Sorry, I think the problems that I encountered follow from my using the old version of the API. I'll use your version and restart again!

mircealungu commented 2 months ago

ok, but even with the new API version, I still get this:

image

And the scheduling code is a bit too complicated for me, or I'm a bit tired. Let's look at it together on Monday!