zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Update extension communication #336

Closed tfnribeiro closed 2 months ago

tfnribeiro commented 3 months ago
netlify[bot] commented 3 months ago

Deploy Preview for voluble-nougat-015dd1 failed.

Name Link
Latest commit c6df3cd252b468207021f3af5fbbb2df8bcdf6dc
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/6622da6ea7deaa0008014034
tfnribeiro commented 2 months ago

When you say move the whole thing into a hook, what do you mean exactly? Right now, we are only setting the variable hasExtension, so the hook would just checking for the extension and setting a variable?

I have now moved the logic all inside the extensionCommunication, including the timeout for the communication.

It's also confirmed that Firefox injects the code first thing:

image

While chrome has a delay, explaining why we need that timeout:

image

NOTE: We had a message in the mobile with no extension, I decided to remove, but the modal remains?

Let me know what you think!