search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Merge with `main` after #372 - Reorder Info pages so that language selection comes before registration #377

Closed igawaclawska closed 1 month ago

igawaclawska commented 1 month ago

What's new:

This branch is created from and dependent on the word-exclusion branch. Thus, this PR should be merged with word-exclusion or with the main after merging #372

The Language Preferences info page comes before the Create Account page.

Changes on the Landing Page:

homepage

Given that the call to action button sends the user to the language preferences first, I have replaced its previous text "Create Beta Account" with "Get Started".

Changes on the Login page

login

The "Don't have an account? Get Started" bottom link redirects the user to the language selection as well, as it is now the first step to register.

Changes on the Language Preferences

registration

The Language Preferences page now informs the user about the invite code in the next step to avoid the frustration of having to request it in the middle of the process.

Changes on the Registration Page

registration

As the paragraph mentioning the invite-code has been moved to the language selection - it's now removed from here. In case someone missed it in the previous step - the email address for requesting the invite-code is now placed as helper text underneath its respective input field.
Moreover, since we now add all the details of a user, including language preferences, when we create a user, the addBasicUser function is no longer used. Now, the old addUser that requires languages is incorporated.

netlify[bot] commented 1 month ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit df69353efbbdfd44d70ea7bc448f2775da5282c4
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/6647486265311e0008408ee7
Deploy Preview https://deploy-preview-377--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mircealungu commented 1 month ago

@igawaclawska - I've merged #372 into #master but now, I still see a lot of commits that were in that PR in the Diff here. I am not sure why this happens. I think we will have to cherry pick the commits that implement this feature?

The easiest thing for me would be if you

  1. closed this PR
  2. updated (rebased) the master of your fork from master of zeeguu/web
  3. created a new branch in which you cherry picked exactly those commits that are relevant for the language selection first
  4. open a new PR with the selection firs

Do you see what I mean?

Tak! M.

igawaclawska commented 1 month ago

@mircealungu, thank you for letting me know. I will close this PR and open a new one. Also, I am currently working on updating the landing page's UI and will have PR ready with these changes tomorrow.