search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Support Endless scrolling #390

Closed tfnribeiro closed 1 month ago

tfnribeiro commented 1 month ago

This only works when combined with the changes introduced in https://github.com/zeeguu/api/pull/154

Move the functions to get the scroll location to a utility function as they might be useful in other places. I decide to use absolute pixels to avoid expanding the articles to much and loading the articles despite not having scrolled to the end.

Otherwise the users will see the loading animation at the bottom of the articles indefinitely.

Question: Should we limit the total articles a user can retrieve? At the moment I can see that they can keep going, I scrolled for a while and I got to 639 articles, it will still work but maybe it is a lot of information to keep storing all the articles?

netlify[bot] commented 1 month ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit 4d0759fc61c311006b64efbfca5bb5d14a3b814e
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/66598e9995ae6100089cb429
Deploy Preview https://deploy-preview-390--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tfnribeiro commented 1 month ago

Changed the the methods to named parameters, it's a bit strange to have to pass an empty dictionary if you just want to call the method without a parameter, let me know what you think.

Updated the tab name:

image

image

mircealungu commented 1 month ago

Changed the the methods to named parameters, it's a bit strange to have to pass an empty dictionary if you just want to call the method without a parameter, let me know what you think.

yeah, it's a bit strange :) but it's a bit clearer I think. and you could still make it work w/o any parameter if you test for the undefinedness of the parameter in the method. or?

tfnribeiro commented 1 month ago

Changed the the methods to named parameters, it's a bit strange to have to pass an empty dictionary if you just want to call the method without a parameter, let me know what you think.

yeah, it's a bit strange :) but it's a bit clearer I think. and you could still make it work w/o any parameter if you test for the undefinedness of the parameter in the method. or?

I did think about that, but you have an object as a parameter which isn't a named object so I don't know how to test if it's defined or not. I think we can leave it - there's an example on how to use it and I added a comment.