Closed tfnribeiro closed 3 months ago
Name | Link |
---|---|
Latest commit | ec3dd5a33044fe739048a85d6ae52f8c0ce7337b |
Latest deploy log | https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/66632c141de9db000847ed37 |
Deploy Preview | https://deploy-preview-392--voluble-nougat-015dd1.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
One thing I thought about, which is worth considering: If the user edits words during review, should we reschedule words when they come back?
Example (This is from the DEV environment, so no translations):
We can see that the words that weren't selected and not altered by the user are re-added for the user to study. Is this a behaviour we want? Or if the user has edited any of the words, we "freeze" that state and don't change it unless the user edits them?
One thing I thought about, which is worth considering: If the user edits words during review, should we reschedule words when they come back?
Example (This is from the DEV environment, so no translations):
Initial Screen:
I remove 5 words:
I reload the page:
We can see that the words that weren't selected and not altered by the user are re-added for the user to study. Is this a behaviour we want? Or if the user has edited any of the words, we "freeze" that state and don't change it unless the user edits them?
This is much more complicated than I've ever imagined :)
solutions
I am tempted to let 1 happen. Let's see how people use this feature first before investing more in it.
@mircealungu But it's not that hard to implement the behavior of nothing changing. Here's how I did it:
This ensures if there is any bookmarks with user preference, then it's safe to assume the user has altered the original list - and that should cover most cases. This seeks to avoid the fact that I reduced the list to... say 2 words, and then I come back and have 10 again?
This has become quite a large change, but I will try to summarize the changes included.
This requires API changes: https://github.com/zeeguu/api/pull/156
Main features:
user_preference
field which overrides, either positively or negatively thefit_for_study
status.fit_for_study
when we want to limit the schedule to simply 10 words per article.user_preference
Screencaps:
Review Word Screen
Review Word Screen (Editing)
Review Word Screen - InfoBox after user Edits
Review Word Screen - InfoBox if no words for exercises
New Edit Word Screen