search

zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

improved word overview and TranslateWhatYouHear component #404

Open merleschoen opened 3 weeks ago

merleschoen commented 3 weeks ago

Previously, the Translate What You Hear exercise only showed the context as a hint. Now it first shows the context and then provides the first letter of the solution, if the user asked for another hint. So the context is not considered a hint in the database anymore. I've also refactored the code to avoid duplication and re-rendering of the component when it's not necessary.

Screenshot 2024-06-13 at 10 10 28

This PR also includes a slight layout improvement of the word overview for small screen sizes. The text is now smaller and the icon has been moved to the top.

Screenshot 2024-06-13 at 09 39 18 Screenshot 2024-06-13 at 09 39 01

netlify[bot] commented 3 weeks ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit 1181be3d54a029cc580f626c73ae88dfb44a0405
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/666aa9cb6900f1000852a4d5
Deploy Preview https://deploy-preview-404--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mircealungu commented 1 week ago

ehi @tfnribeiro @merleschoen - what's the state of this PR?

tfnribeiro commented 1 week ago

I don't think any work has been done on this since our last discussion, and while I remember discussing it I am not sure what we landed on @merleschoen. Was it something like we would go with this one, and then some more refactoring would be done? I also don't recall if we agreed to leave two "HH" and just accept that in the backend, since the philosophy is that a hit can never be too much close to the answer.

tfnribeiro commented 1 week ago

I have attempted to implement the logic by allowing the parent to decide when to give the hint inside the bottomInput in this branch:

https://github.com/zeeguu/web/tree/parent-controls-input-hint

merleschoen commented 1 week ago

We agreed on that hints should not be part of the BottomInput. We also agreed on that this is not really part of my thesis, so that @tfnribeiro would look into it (which he apparently already did 😄 ).

I think that for now this PR is fine and the refactoring can be done later, since the current code also includes exercise specific logic in the BottomInput, but I'm obviously biased 😉