netlify[bot]
commented
2 weeks ago Deploy Preview for voluble-nougat-015dd1 ready!
| Name | Link |
|---|---|
| Latest commit | f243128b82d4df9a9f99ee787ea5e4338db21704 |
| Latest deploy log | https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/6674260b34a32c00085f1422 |
| Deploy Preview | https://deploy-preview-406--voluble-nougat-015dd1.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Whenever a user would update the language they were learning it could cause a concurrency issue in the backend if they had not selected the language before.
To fix this, I have made changes on how the Save is handled both in the Web and API to simply do it in one endpoint call, rather than multiple endpoint calls.
The user preferences are handled separately, as these are not needed for the user details update.
Implementation:
modifyCEFRlevel- is no longer called in the settings. Maybe if at some point we have a component that needs this individual update it's still available to be called. I believe this was the cause for the concurrency - as we would call a setUserLanguageboth here and insaveUserDetails.saveUserDetailswill now update all the fields that are being edited in the frontend - ensure they mirror what the user inputs.api.isaveUserPreferencesandapi.saveUserDetailsdo not wait for each other as they are independent of their own updates.Depends on:
https://github.com/zeeguu/api/pull/165