zeeguu / web

Frontend for the zeeguu web application.
https://www.zeeguu.org
3 stars 5 forks source link

Fix Edit Form Sending Toasty when No edit was made #415

Open tfnribeiro opened 5 days ago

tfnribeiro commented 5 days ago

Issue: If the user opens the Edit word, it will send the "Thank you for the contribution!" toasty even if the user has not edited the bookmark.

I found out that the condition to test if anything had been edited from the edit form was incorrect.

It was trying to access an undefined property 'fitForStudy' instead of the correct 'fit_for_study'.

I have moved this to a constant to be easier to call rather than having multiple places where it's re-written.

netlify[bot] commented 5 days ago

Deploy Preview for voluble-nougat-015dd1 ready!

Name Link
Latest commit 4f23d81365d16495b1c447bc64ca0ddc9326ff4c
Latest deploy log https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/6683aea05ccfd00008eca2be
Deploy Preview https://deploy-preview-415--voluble-nougat-015dd1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.