Closed tfnribeiro closed 1 month ago
Name | Link |
---|---|
Latest commit | d81dc6094e07ecce5de192e81801ab194cacfac6 |
Latest deploy log | https://app.netlify.com/sites/voluble-nougat-015dd1/deploys/669535e12c620e0008e444d4 |
Deploy Preview | https://deploy-preview-420--voluble-nougat-015dd1.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
before merging, made a few changes in https://github.com/zeeguu/web/pull/420/commits/d81dc6094e07ecce5de192e81801ab194cacfac6:
EditButton
to EditBookmarkButton
setDeleted
param from the EditBookmarkButton
. It's not normal for the button to tamper directly with the parent's state. Instead in case the bookmak is deleted, the only thing that is being done is that the notifyDeleted(bookmark)
is being called; it's up to the parent to setDeleted
if that makes sense in their context.EditBookmarkButton#deleteBookmark
is now testing that the deletion was successful; if not it shows a failure message;
Before Deleting the bookmark was associated with the Word component (the trash icon, but now since we have moved the delete action to the edit form, it doesn't make sense to have this action in the word component.