when in only pronounciation mode, we should still underline the word, even if it's not translated

zeeguu / web

Frontend for the zeeguu web application.

https://www.zeeguu.org

4 stars 7 forks source link

when in only pronounciation mode, we should still underline the word, even if it's not translated #442

Closed mircealungu closed 1 month ago

mircealungu commented 1 month ago

pronouncing skriver leaves it completely unmarked:

given that we currently the semantics of dotted underline is pronounce in the reader, it should look like this:

tfnribeiro commented 1 month ago

Shouldn't this be moved into the web repository?

I can change the visual feedback when using hear pronunciation to just highlight the word.

mircealungu commented 1 month ago

yes, it's a web issue. let me see if i can move it!

tfnribeiro commented 1 month ago

I have made the change:

However, a question arrives, what should happen if you clicked to Hear Pronounce and then untoggle the hear pronunciation and click the highlighted word:

E.g.: What happens here when I click 'løbe' or 'stærkt' @mircealungu?

I see some options:

We do not pronounce the word now, since the interaction says On Click X happens
We hide the pronounced words (this could similarly be implemented for the translation), resulting in the original text with no styling.
We keep pronouncing the words that have special styling, but not any new words.

mircealungu commented 1 month ago

Super good question! I guess 1 or 3 would be most intuitive for me? Maybe with a tendency towards 3? What do you think?

tfnribeiro commented 1 month ago

Yeah, I think 3 is consistent with the visual indication and doesn't change much of what's already on the screen. I will do that!